Add support for design matrix keyword in ert config #8803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsevj
force-pushed
the
add_support_for_design_matrix_keyword
branch
from
7cb27a8 to
7da32b3
Compare
xjules
reviewed
Sep 27, 2024
xjules
reviewed
Sep 27, 2024
larsevj
force-pushed
the
add_support_for_design_matrix_keyword
branch
from
7da32b3 to
f29e219
Compare
|
Wondering if I should separate the dataclass |
I was actually thinking the same :) Let's move it to a standalone file 👍 |
xjules
reviewed
Sep 30, 2024
| def test_invalid_design_matrix_format_raises_validation_error(): | ||
| with pytest.raises( | ||
| ConfigValidationError, | ||
| match="DESIGN_MATRIX must be of format .xls or .xslx; is 'my_matrix.txt'", |
There was a problem hiding this comment.
This needs to be updated:
tests/ert/unit_tests/config/test_analysis_config.py::test_invalid_design_matrix_format_raises_validation_error - AssertionError: Regex pattern did not match.
Regex: "DESIGN_MATRIX must be of format .xls or .xslx; is 'my_matrix.txt'"
Input: 'DESIGN_MATRIX must be of format .xls or .xslx; is my_matrix.txt'
larsevj
force-pushed
the
add_support_for_design_matrix_keyword
branch
from
f29e219 to
138faf4
Compare
larsevj
added
the
release-notes:new-feature
larsevj
force-pushed
the
add_support_for_design_matrix_keyword
branch
2 times, most recently
from
6ccd250 to
d3fbff2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8803 +/- ##
==========================================
+ Coverage 91.31% 91.38% +0.07%
==========================================
Files 342 343 +1
Lines 21028 21063 +35
==========================================
+ Hits 19202 19249 +47
+ Misses 1826 1814 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
larsevj
force-pushed
the
add_support_for_design_matrix_keyword
branch
from
d3fbff2 to
aee9f51
Compare
- Expects the format: DESIGN_MATRIX file.xlsx DESIGN_SHEET:design DEFAULT_SHEET:default where file.xlsx is an existing file. - Scaffolding for further support for reading parameter values from design matrix excel files.
larsevj
force-pushed
the
add_support_for_design_matrix_keyword
branch
from
aee9f51 to
ae264ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #8689
Adds the new keyword
DESIGN_MATRIXto ert config. Intended to be used to read a design_matrix excel file for sensitivity analysis in the future.No documentation, will probably be better to write this after it is fully functional.
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable