Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all tests in test_komodo before returning error #8797

Merged

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Sep 25, 2024

Avoid exiting tests early if one of the test suites fail during komodo testing.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@larsevj larsevj added the release-notes:skip If there should be no mention of this in release notes label Sep 25, 2024
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also run everest tests now.

@larsevj
Copy link
Contributor Author

larsevj commented Sep 25, 2024

Yes, exists an issue for it #8783

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.33%. Comparing base (e581b2e) to head (da148f7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8797      +/-   ##
==========================================
- Coverage   91.34%   91.33%   -0.01%     
==========================================
  Files         342      342              
  Lines       20985    20985              
==========================================
- Hits        19168    19167       -1     
- Misses       1817     1818       +1     
Flag Coverage Δ
cli-tests 39.45% <ø> (-0.15%) ⬇️
gui-tests 73.49% <ø> (ø)
performance-tests 50.06% <ø> (ø)
unit-tests 79.81% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@larsevj larsevj merged commit e2d3a90 into equinor:main Sep 25, 2024
50 checks passed
@larsevj larsevj deleted the run_all_tests_in_komodo_before_erroring branch September 25, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants