-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move tool buttons to side pane #8703
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8703 +/- ##
==========================================
- Coverage 90.82% 90.69% -0.13%
==========================================
Files 352 349 -3
Lines 21759 21774 +15
==========================================
- Hits 19762 19749 -13
- Misses 1997 2025 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fa37477
to
e00765f
Compare
1160736
to
f016e3a
Compare
f705166
to
ef36952
Compare
fa4568b
to
852e3a4
Compare
0c0f562
to
5d2ed74
Compare
I agree we should replace the start button. Could any of these be an alternative? We are a bit limited by what EDS provides in the context of icons. https://storybook.eds.equinor.com/?path=/docs/icons-preview--docs |
79d7e07
to
3b8b305
Compare
My vote would be on the library_add button |
548f2a7
to
dd92fe1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing! 👯
Updated with library_add icon and renew plotter on subsequent clicks.
TGX
macOS
Update after comments
Added visual padding, reversed names in menu, added experiment type in menu description.
Issue
Resolves #8702
When applicable
TODO:
Error: Image dimensions did not match