-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable load results manually from any available iteration #8700
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8700 +/- ##
==========================================
- Coverage 90.81% 90.74% -0.07%
==========================================
Files 351 352 +1
Lines 21895 21926 +31
==========================================
+ Hits 19884 19897 +13
- Misses 2011 2029 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
949265d
to
814ffd2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure we don't want a dropdown to enforce the selection of a valid iteration, rather than a text field (unless you want to be able to select multiple iterations etc?)
Sure we can convert it to a dropdown but that was not the focus of the parent issue. I can add an issue if you think a dropdown is more appropriate in this case.
I am unsure it is possible to load data from multiple iterations into one ensemble. |
814ffd2
to
ddc33f6
Compare
I created the issue #8819 to keep track of the dropdown conversion idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think we need to rethink a bit how we do this, so everything is kept in sync.
4468068
to
caecbbf
Compare
b3fe922
to
313caf9
Compare
Some tests are still needed for some of the new functionality but the implementation is ready for a review. |
39c24d2
to
4633e18
Compare
Doing some testing, and looks good so far! It would be great if I also could see what f"<IENS> will be replace by: {ensemble.iteration}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good improvement to me, a few minor questions
4633e18
to
009e0ef
Compare
…r using CreateExperimentDialog
43ece93
to
c4f70aa
Compare
c4f70aa
to
af611f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Issue
Resolves #8640
(Screenshot of new behavior in GUI if applicable)
Loading data
Checking plot results:
When applicable