Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable load results manually from any available iteration #8700

Merged
merged 11 commits into from
Nov 11, 2024

Conversation

DanSava
Copy link
Contributor

@DanSava DanSava commented Sep 16, 2024

Issue
Resolves #8640

(Screenshot of new behavior in GUI if applicable)

Loading data
image

Checking plot results:
image

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@DanSava DanSava self-assigned this Sep 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 98.24561% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.74%. Comparing base (90d11ec) to head (af611f7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...c/ert/gui/tools/load_results/load_results_panel.py 92.85% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8700      +/-   ##
==========================================
- Coverage   90.81%   90.74%   -0.07%     
==========================================
  Files         351      352       +1     
  Lines       21895    21926      +31     
==========================================
+ Hits        19884    19897      +13     
- Misses       2011     2029      +18     
Flag Coverage Δ
cli-tests 39.22% <24.56%> (-0.03%) ⬇️
gui-tests 71.77% <92.10%> (+0.03%) ⬆️
performance-tests 49.35% <35.96%> (-0.02%) ⬇️
unit-tests 79.65% <56.14%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanSava DanSava force-pushed the load-results-manually branch 3 times, most recently from 949265d to 814ffd2 Compare September 20, 2024 05:55
Copy link
Contributor

@yngve-sk yngve-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure we don't want a dropdown to enforce the selection of a valid iteration, rather than a text field (unless you want to be able to select multiple iterations etc?)

@DanSava
Copy link
Contributor Author

DanSava commented Sep 23, 2024

Sure we don't want a dropdown to enforce the selection of a valid iteration, rather than a text field.

Sure we can convert it to a dropdown but that was not the focus of the parent issue. I can add an issue if you think a dropdown is more appropriate in this case.

(unless you want to be able to select multiple iterations etc?)

I am unsure it is possible to load data from multiple iterations into one ensemble.

@DanSava DanSava force-pushed the load-results-manually branch from 814ffd2 to ddc33f6 Compare September 25, 2024 06:36
@DanSava
Copy link
Contributor Author

DanSava commented Sep 30, 2024

I created the issue #8819 to keep track of the dropdown conversion idea.

Copy link
Collaborator

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we need to rethink a bit how we do this, so everything is kept in sync.

src/ert/run_arg.py Outdated Show resolved Hide resolved
src/ert/libres_facade.py Show resolved Hide resolved
@DanSava DanSava force-pushed the load-results-manually branch 2 times, most recently from 4468068 to caecbbf Compare October 8, 2024 13:09
@DanSava DanSava force-pushed the load-results-manually branch 3 times, most recently from b3fe922 to 313caf9 Compare October 10, 2024 12:33
@DanSava
Copy link
Contributor Author

DanSava commented Oct 10, 2024

Some tests are still needed for some of the new functionality but the implementation is ready for a review.

@DanSava DanSava force-pushed the load-results-manually branch 2 times, most recently from 39c24d2 to 4633e18 Compare October 28, 2024 09:44
@oyvindeide
Copy link
Collaborator

Doing some testing, and looks good so far! It would be great if I also could see what <ITER> would be replaced by in the runpath (read only), adding a text field with for example:

f"<IENS> will be replace by: {ensemble.iteration}"

Copy link
Collaborator

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good improvement to me, a few minor questions

src/ert/callbacks.py Outdated Show resolved Hide resolved
src/ert/libres_facade.py Show resolved Hide resolved
@DanSava DanSava force-pushed the load-results-manually branch from 4633e18 to 009e0ef Compare November 1, 2024 09:39
@DanSava DanSava force-pushed the load-results-manually branch 4 times, most recently from 43ece93 to c4f70aa Compare November 4, 2024 09:19
@DanSava DanSava force-pushed the load-results-manually branch from c4f70aa to af611f7 Compare November 4, 2024 09:30
Copy link
Collaborator

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DanSava DanSava merged commit 1b29b3a into equinor:main Nov 11, 2024
56 checks passed
@DanSava DanSava deleted the load-results-manually branch November 11, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not possible to load results manually from other iteration than "ensemble.iteration"
4 participants