Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace selected usage of SIMULATION_JOB with FORWARD_MODEL #8698

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

berland
Copy link
Contributor

@berland berland commented Sep 13, 2024

Wherever there are no arguments passed directly from the config line, FORWARD_MODEL is used instead of SIMULATION_JOB.

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.47%. Comparing base (47c7f5f) to head (f7faeee).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8698      +/-   ##
==========================================
+ Coverage   90.96%   91.47%   +0.50%     
==========================================
  Files         343      343              
  Lines       21286    21286              
==========================================
+ Hits        19363    19471     +108     
+ Misses       1923     1815     -108     
Flag Coverage Δ
cli-tests 38.76% <ø> (?)
gui-tests 72.31% <ø> (-3.93%) ⬇️
integration-tests ?
performance-tests 49.24% <ø> (?)
unit-tests 80.09% <ø> (+11.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@berland berland self-assigned this Sep 16, 2024
Wherever there are no arguments passed directly from the config
line, FORWARD_MODEL is used instead of SIMULATION_JOB.
@berland berland added the release-notes:skip If there should be no mention of this in release notes label Sep 16, 2024
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@berland berland merged commit d69bbe3 into equinor:main Sep 16, 2024
35 checks passed
@berland berland deleted the simul-fm branch October 9, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants