Log contents of custom forward model steps #8696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berland
added
the
release-notes:misc
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8696 +/- ##
==========================================
+ Coverage 90.96% 91.44% +0.47%
==========================================
Files 343 343
Lines 21286 21292 +6
==========================================
+ Hits 19363 19470 +107
+ Misses 1923 1822 -101
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eivindjahren
requested changes
Sep 16, 2024
| schema=init_user_config_schema(), | ||
| ) | ||
| for fm_step, fm_step_filename in user_config.get(ConfigKeys.INSTALL_JOB, []): | ||
| fm_configuration = Path(fm_step_filename).read_text(encoding="utf-8") |
There was a problem hiding this comment.
This should probably be logged after the ErtConfig is parsed to avoid 1) parsing the config file twice and 2) avoid raising FileNotFoundError instead of ConfigurationValidationError.
There was a problem hiding this comment.
Just checked and bad permissions for the config file and non-existent config file is handled by __main__.py.
berland
force-pushed
the
log_fm_steps
branch
from
4f0deaf to
37a3644
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves https://github.com/equinor/scout/issues/1132
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
When applicable