Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FORWARD_MODEL in poly-example #8694

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

berland
Copy link
Contributor

@berland berland commented Sep 13, 2024

No need to use the keyword SIMULATION_JOB that no users use.

Issue
Resolves an itch

Approach
do-it

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

No need to use the keyword SIMULATION_JOB that no users use.
@berland berland added the release-notes:skip If there should be no mention of this in release notes label Sep 13, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.88%. Comparing base (d8b17e4) to head (e379b4c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8694      +/-   ##
==========================================
- Coverage   90.90%   90.88%   -0.02%     
==========================================
  Files         343      343              
  Lines       21271    21271              
==========================================
- Hits        19336    19333       -3     
- Misses       1935     1938       +3     
Flag Coverage Δ
gui-tests 76.11% <ø> (-0.01%) ⬇️
integration-tests 53.38% <ø> (-0.04%) ⬇️
unit-tests 68.99% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@berland berland enabled auto-merge (rebase) September 13, 2024 12:54
Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@berland berland merged commit d347cb4 into equinor:main Sep 13, 2024
35 checks passed
@berland berland deleted the poly_forward branch September 17, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants