Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove excess check_response call in std_dev_for_parameter #8672

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

jonathan-eq
Copy link
Contributor

@jonathan-eq jonathan-eq commented Sep 10, 2024

Issue
Resolves #8638

Approach
✂️

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@jonathan-eq jonathan-eq self-assigned this Sep 10, 2024
@jonathan-eq jonathan-eq added maintenance Not a bug now but could be one day, repaying technical debt release-notes:skip If there should be no mention of this in release notes labels Sep 10, 2024
The `std_dev_for_parameter` method manually checks if the response's status_code is
200 OK and decides what to do if it is not. Calling the `check_response`
method raises an exception if it is not 200 OK, which is a valid
response in this case.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.87%. Comparing base (e0e9d97) to head (7fdb45a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8672      +/-   ##
==========================================
- Coverage   90.88%   90.87%   -0.01%     
==========================================
  Files         339      339              
  Lines       21020    21019       -1     
==========================================
- Hits        19103    19100       -3     
- Misses       1917     1919       +2     
Flag Coverage Δ
gui-tests 76.33% <ø> (+0.02%) ⬆️
integration-tests 53.38% <ø> (-0.01%) ⬇️
unit-tests 68.42% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonathan-eq jonathan-eq merged commit 1cd56d4 into equinor:main Sep 11, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Not a bug now but could be one day, repaying technical debt release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError while plotting standard deviation
3 participants