(Everest) Use one experiment per optimization #8670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yngve-sk
force-pushed
the
everest-one-experiment-per-enopt-run
branch
3 times, most recently
from
56ae36b to
d7e0fff
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8670 +/- ##
==========================================
- Coverage 91.36% 91.36% -0.01%
==========================================
Files 342 342
Lines 20995 20994 -1
==========================================
- Hits 19183 19182 -1
Misses 1812 1812
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yngve-sk
force-pushed
the
everest-one-experiment-per-enopt-run
branch
from
d7e0fff to
048db32
Compare
verveerpj
approved these changes
Sep 13, 2024
src/ert/simulator/batch_simulator.py
Outdated
| @@ -91,6 +92,7 @@ def callback(*args, **kwargs): | |||
| self.control_keys = set(controls.keys()) | |||
| self.result_keys = set(results) | |||
| self.callback = callback | |||
| self._experiment_id: Optional[UUID] = None | |||
There was a problem hiding this comment.
_experiment_id does not seem to be used?
yngve-sk
force-pushed
the
everest-one-experiment-per-enopt-run
branch
2 times, most recently
from
904aa5b to
fa268e0
Compare
yngve-sk
force-pushed
the
everest-one-experiment-per-enopt-run
branch
from
fac1eae to
53dca44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves equinor/everest#118