Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug info to clipboard capability #8639

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

andreas-el
Copy link
Contributor

@andreas-el andreas-el commented Sep 4, 2024

Issue
Resolves #8582

Pressing F1 or using the button in run_dialog will yield this markdown in your clipboard

(screenshot and printout are from different runs)

Platform
Date 2024-09-09 09:36:28
OS Linux 4.18.0-553.8.1.el8_10.x86_64 x86_64
Hostname st-lintgx0138.st.statoil.no
Komodo release /private/andrli/rhel8-bleed-env
Python version 3.8.17
Ensemble
Queue Lsf
Simulation mode Ensemble experiment
Config file /private/andrli/project/ert/test-data/poly_example/poly.ert
Storage path /private/andrli/project/ert/test-data/poly_example/storage
Run path /private/andrli/project/ert/test-data/poly_example/poly_out/realization-/iter-
Ensemble size 100
Realization memory 52.43 MB
Max running 50
Submit sleep 1.0
Lsf queue mr8
Lsf resource select[cs && x86_64Linux] rusage[mem=7000]
Status
Running time 10 seconds
Ert max memory 463.44 KB
Forward model max memory 892.93 KB
Running 1
Pending 4
Waiting 95

Screenshot 2024-09-05 at 13 52 36

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@andreas-el andreas-el force-pushed the keypress_logging_info branch from 3adcee8 to d749a37 Compare September 4, 2024 11:30
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 89.32039% with 11 lines in your changes missing coverage. Please review.

Project coverage is 90.87%. Comparing base (fd5fa70) to head (ad3374b).

Files with missing lines Patch % Lines
src/ert/gui/simulation/experiment_panel.py 92.72% 4 Missing ⚠️
src/ert/gui/simulation/run_dialog.py 70.00% 3 Missing ⚠️
src/ert/run_models/base_run_model.py 87.50% 3 Missing ⚠️
src/ert/shared/status/utils.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8639      +/-   ##
==========================================
- Coverage   90.88%   90.87%   -0.02%     
==========================================
  Files         339      339              
  Lines       20933    21020      +87     
==========================================
+ Hits        19026    19101      +75     
- Misses       1907     1919      +12     
Flag Coverage Δ
gui-tests 76.30% <86.40%> (+0.03%) ⬆️
integration-tests 53.38% <33.98%> (-0.12%) ⬇️
unit-tests 68.42% <40.77%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreas-el andreas-el force-pushed the keypress_logging_info branch from 4459b5b to 567816a Compare September 5, 2024 10:22
@andreas-el andreas-el force-pushed the keypress_logging_info branch from 9e4acd3 to f1a878a Compare September 5, 2024 11:50
@andreas-el andreas-el added the release-notes:new-feature Automatically categorise as new feature in release notes label Sep 5, 2024
@andreas-el andreas-el force-pushed the keypress_logging_info branch 2 times, most recently from 273b2b0 to cdbff4f Compare September 6, 2024 08:14
kv["Config file"] = self._config_file
kv["Ensemble path"] = self.config.ens_path
kv["Ensemble size"] = str(self._model.ensemble_size)
kv["Max running"] = str(self.config.queue_config.queue_options.max_running)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could possibly list all the values in the queue_options class, or only non-defaulted (or if the latter is tricky, all the non-None values).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opted for the non-None variant. Looking at LSF-options there were mostly those variants. Other systems like Torque or Slurm had some extras, but we can rather expand on that if need be.

@andreas-el andreas-el force-pushed the keypress_logging_info branch 3 times, most recently from e311bb1 to 017c669 Compare September 9, 2024 07:41
@andreas-el andreas-el requested a review from berland September 9, 2024 07:45
@andreas-el andreas-el force-pushed the keypress_logging_info branch from 017c669 to 33229bf Compare September 9, 2024 10:53
@berland
Copy link
Contributor

berland commented Sep 10, 2024

Good to go, just some rebasing (and Everest is maybe fixed by now?)

@andreas-el andreas-el force-pushed the keypress_logging_info branch from 33229bf to ad3374b Compare September 10, 2024 08:38
Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go!

@andreas-el andreas-el merged commit e0e9d97 into equinor:main Sep 10, 2024
35 checks passed
@andreas-el andreas-el deleted the keypress_logging_info branch September 10, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:new-feature Automatically categorise as new feature in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make copying all debug info a one click operation in the ert gui
3 participants