Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose environment variables with run information in compute nodes #8540

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

DanSava
Copy link
Contributor

@DanSava DanSava commented Aug 21, 2024

Issue
Resolves #8515

Approach

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@DanSava DanSava self-assigned this Aug 21, 2024
@DanSava DanSava force-pushed the expose_env_vars branch 2 times, most recently from bcc68cf to 4d29b64 Compare August 21, 2024 12:02
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.76%. Comparing base (fbfd095) to head (31a2cfe).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8540      +/-   ##
==========================================
+ Coverage   90.68%   90.76%   +0.07%     
==========================================
  Files         342      342              
  Lines       20933    20945      +12     
==========================================
+ Hits        18983    19010      +27     
+ Misses       1950     1935      -15     
Flag Coverage Δ
gui-tests 75.82% <77.77%> (+0.04%) ⬆️
integration-tests 53.95% <77.77%> (-0.05%) ⬇️
unit-tests 68.78% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sondreso
Copy link
Collaborator

I think another approach that is possible here is to send in system env vars to forward_model_data_to_json and join them with the user specific ones. Then it will be very explicit what the source of the env vars are.

@DanSava DanSava force-pushed the expose_env_vars branch 4 times, most recently from 38e7ee6 to 3197b7c Compare August 26, 2024 11:56
@DanSava
Copy link
Contributor Author

DanSava commented Aug 26, 2024

I think another approach that is possible here is to send in system env vars to forward_model_data_to_json and join them with the user specific ones. Then it will be very explicit what the source of the env vars are.

Done

@DanSava DanSava marked this pull request as ready for review August 26, 2024 13:52
@DanSava DanSava added the release-notes:new-feature Automatically categorise as new feature in release notes label Aug 28, 2024
Copy link
Contributor

@yngve-sk yngve-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, env vars written to jobs.json env entries via create_run_path seems like a sensible way to do it

@DanSava DanSava merged commit c6c77d1 into equinor:main Aug 28, 2024
35 checks passed
@DanSava DanSava deleted the expose_env_vars branch August 28, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:new-feature Automatically categorise as new feature in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose environment variables with run information in compute nodes
4 participants