Rename port_handler functions #8481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-eq
force-pushed
the
port_handler
branch
5 times, most recently
from
5ec2d52 to
4703730
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8481 +/- ##
==========================================
+ Coverage 90.84% 90.85% +0.01%
==========================================
Files 339 339
Lines 20855 20852 -3
==========================================
Hits 18946 18946
+ Misses 1909 1906 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
berland
reviewed
Aug 20, 2024
jonathan-eq
force-pushed
the
port_handler
branch
2 times, most recently
from
1d9d9fa to
fbbd9e1
Compare
xjules
reviewed
Sep 2, 2024
| @@ -151,8 +151,6 @@ def get_socket(self) -> socket.socket: | |||
|
|
|||
| def get_connection_info(self) -> EvaluatorConnectionInfo: | |||
| return EvaluatorConnectionInfo( | |||
| self.host, | |||
| self.port, | |||
xjules
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Very good PR @jonathan-eq ! Just update the commit message, where you describe find_available_socket API and do the rebase. 🚀
jonathan-eq
force-pushed
the
port_handler
branch
from
fbbd9e1 to
9bfe22c
Compare
jonathan-eq
added
maintenance
This commit changes `port_handler.py` -> `net_utils.py` and cleans up the functions in the file. `find_available_port` is now called `find_available_socket`, and only returns the socket. The caller can use the socket object to get the attached hostname and port, so this is no longer explicitly returned.
jonathan-eq
force-pushed
the
port_handler
branch
from
9bfe22c to
71f870c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #8407
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
When applicable