Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WaitCursor to some slow tasks in the GUI #6131

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

frode-aarstad
Copy link
Contributor

Issue
Resolves #6025

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@frode-aarstad frode-aarstad self-assigned this Sep 21, 2023
@frode-aarstad frode-aarstad force-pushed the create-experiment-dialog branch from fef3087 to 2a8182a Compare September 21, 2023 07:47
@codecov-commenter
Copy link

Codecov Report

Merging #6131 (fef3087) into main (526c565) will increase coverage by 16.84%.
Report is 27 commits behind head on main.
The diff coverage is 75.00%.

❗ Current head fef3087 differs from pull request most recent head 2a8182a. Consider uploading reports for the commit 2a8182a to get more accurate results

@@             Coverage Diff             @@
##             main    #6131       +/-   ##
===========================================
+ Coverage   65.62%   82.47%   +16.84%     
===========================================
  Files         349      350        +1     
  Lines       21495    21453       -42     
  Branches      817      834       +17     
===========================================
+ Hits        14107    17693     +3586     
+ Misses       7092     3462     -3630     
- Partials      296      298        +2     
Files Changed Coverage Δ
src/ert/gui/tools/plot/plot_window.py 85.46% <66.66%> (+64.28%) ⬆️
src/ert/gui/simulation/simulation_panel.py 96.55% <100.00%> (+74.62%) ⬆️

... and 143 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@frode-aarstad frode-aarstad merged commit 1ce3284 into equinor:main Sep 25, 2023
39 checks passed
@frode-aarstad frode-aarstad deleted the create-experiment-dialog branch September 25, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage.create_experiments is slow
3 participants