Add Flake8-pyproject to fix python annotation workflow #6123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JHolba
added
the
release-notes:skip
JHolba
force-pushed
the
fix-flake8-workflow
branch
from
264a5c2 to
5223121
Compare
berland
reviewed
Sep 20, 2023
| @@ -18,7 +18,7 @@ jobs: | |||
| with: | |||
| python-version: "3.11" | |||
| - name: Install flake8 | |||
| run: pip install flake8 flake8-bugbear flake8-simplify flake8-debugger flake8-pep3101 | |||
| run: pip install flake8 flake8-bugbear flake8-simplify flake8-debugger flake8-pep3101 Flake8-pyproject | |||
There was a problem hiding this comment.
This can be simplified into pip install -r style-requirements.txt and then only -pep3101 and -debugger is needed
There was a problem hiding this comment.
If @dafeda beats you, there will probably be a pip install .[style] or something similar instead of style-requirements.txt.
There was a problem hiding this comment.
do you want me to wait or close this PR then @dafeda?
Codecov Report
@@ Coverage Diff @@
## main #6123 +/- ##
===========================================
+ Coverage 41.17% 82.45% +41.28%
===========================================
Files 20 350 +330
Lines 2186 21442 +19256
Branches 834 834
===========================================
+ Hits 900 17680 +16780
- Misses 988 3464 +2476
Partials 298 298 see 330 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
JHolba
force-pushed
the
fix-flake8-workflow
branch
from
5223121 to
acd92f5
Compare
dafeda
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Approach
Add Flake8-pyproject to fix python annotation workflow
Pre review checklist
Ground Rules),
and changes to existing code have good test coverage.
Pre merge checklist