Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert back to skipping test test_rft_csv_export_plugin_exports_rft_data #6121

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

DanSava
Copy link
Contributor

@DanSava DanSava commented Sep 20, 2023

Issue
Skip test_rft_csv_export_plugin_exports_rft_data to avoid
https://github.com/equinor/ert/actions/runs/6246220951/job/16958563596?pr=6119
while working on actual fix

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@DanSava DanSava self-assigned this Sep 20, 2023
@DanSava DanSava force-pushed the fix_hanging_test_rft_export branch 2 times, most recently from b4b5049 to 2302e83 Compare September 20, 2023 12:28
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

Merging #6121 (d1e213a) into main (c1ab4e6) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #6121      +/-   ##
==========================================
- Coverage   82.48%   82.45%   -0.03%     
==========================================
  Files         350      350              
  Lines       21442    21442              
  Branches      834      834              
==========================================
- Hits        17687    17681       -6     
- Misses       3457     3463       +6     
  Partials      298      298              

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

test_rft_csv_export_plugin_exports_rft_data is still flaky while investigating how to test rft export plugin we should skip it for now.
@DanSava DanSava force-pushed the fix_hanging_test_rft_export branch from d1e213a to 9574c9d Compare September 20, 2023 13:58
@DanSava DanSava changed the title Fix timing issue happening when trying to close message box not there yet Revert back to skipping test test_rft_csv_export_plugin_exports_rft_data Sep 20, 2023
@DanSava DanSava merged commit 6f20447 into equinor:main Sep 20, 2023
39 checks passed
@DanSava DanSava deleted the fix_hanging_test_rft_export branch September 20, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants