Remove JobListReadLock and simplify JobQueue #6114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreas-el
commented
Sep 19, 2023
| @@ -89,10 +89,8 @@ def _queue_state_event_type(state: str) -> str: | |||
| # pylint: disable=too-many-public-methods | |||
| class JobQueue(BaseCClass): # type: ignore | |||
| TYPE_NAME = "job_queue" | |||
| _alloc = ResPrototype("void* job_queue_alloc()", bind=False) | |||
| _alloc = ResPrototype("void* job_queue_alloc(void*)", bind=False) | |||
There was a problem hiding this comment.
Not sure if I got this CWrap thing correct here
andreas-el
commented
Sep 19, 2023
andreas-el
force-pushed
the
refactor_job_queue
branch
4 times, most recently
from
6d5aa68 to
129e822
Compare
andreas-el
force-pushed
the
refactor_job_queue
branch
from
39067ad to
ad65f8f
Compare
andreas-el
force-pushed
the
refactor_job_queue
branch
from
ad65f8f to
662e95a
Compare
andreas-el
changed the title
andreas-el
changed the title
andreas-el
changed the title
andreas-el
added
the
release-notes:maintenance
Codecov Report
@@ Coverage Diff @@
## main #6114 +/- ##
=======================================
Coverage 82.42% 82.42%
=======================================
Files 350 350
Lines 21457 21450 -7
Branches 839 839
=======================================
- Hits 17685 17681 -4
+ Misses 3474 3471 -3
Partials 298 298
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
eivindjahren
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused JobListReadLock
Initialize struct members
Avoid state for JobQueue where alloc returns a not fully functional object before set_driver was executed
Update pybind signatures
Pre review checklist
Ground Rules),
and changes to existing code have good test coverage.
Pre merge checklist