Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 32bit floats for surfaces #6106

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Use 32bit floats for surfaces #6106

merged 1 commit into from
Sep 19, 2023

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Sep 19, 2023

Issue
Resolves #6059

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@dafeda dafeda requested a review from oyvindeide September 19, 2023 08:24
@dafeda dafeda self-assigned this Sep 19, 2023
@dafeda dafeda added the release-notes:improvement Automatically categorise as improvement in release notes label Sep 19, 2023
Set lower limit of xtgeo to 3.3.0 as this version
supports working with surfaces as 32bit floats.
@codecov-commenter
Copy link

Codecov Report

Merging #6106 (8f2c3bd) into main (61ec478) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #6106   +/-   ##
=======================================
  Coverage   82.49%   82.49%           
=======================================
  Files         350      350           
  Lines       21486    21488    +2     
  Branches      826      826           
=======================================
+ Hits        17725    17727    +2     
  Misses       3467     3467           
  Partials      294      294           
Files Changed Coverage Δ
src/ert/storage/migration/block_fs.py 97.89% <ø> (ø)
src/ert/config/surface_config.py 100.00% <100.00%> (ø)
src/ert/storage/local_experiment.py 95.45% <100.00%> (+0.06%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dafeda dafeda merged commit eb7c46c into equinor:main Sep 19, 2023
39 checks passed
@dafeda dafeda deleted the 32bit_surfaces branch September 19, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:improvement Automatically categorise as improvement in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Save surfaces as 32bit instead of as 64bit
3 participants