-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused includes and use default struct initialization #6105
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6105 +/- ##
==========================================
- Coverage 82.50% 82.46% -0.04%
==========================================
Files 350 350
Lines 21486 21435 -51
Branches 826 834 +8
==========================================
- Hits 17726 17677 -49
+ Misses 3466 3461 -5
- Partials 294 297 +3
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
6a775b1
to
07cd369
Compare
stringlist_append_copy(argv, "-l"); | ||
std::string cluster_label; | ||
if (driver->cluster_label == NULL) { | ||
cluster_label = std::string(""); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what happens with the empty string case now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's default initialized to empty string?
e.g.
std::string str{}; // Initializes str to an empty string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, now I get it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! But I had a few concerns.
Built on Mac
Built on Bleeding/komodoenv RGS
Pre review checklist
Ground Rules),
and changes to existing code have good test coverage.
Pre merge checklist