Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip test_rft_csv_export_plugin_exports_rft_data #6102

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

andreas-el
Copy link
Contributor

@andreas-el andreas-el commented Sep 18, 2023

Skip rft_csv_export test that seems to be the cause for Coverage GUI tests to timeout at 40 min runtime.
Ref.
https://github.com/equinor/ert/actions/runs/6142757595/job/16665011088

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@andreas-el andreas-el force-pushed the coverage_gui_race_condition branch from aff34dd to c1476b2 Compare September 18, 2023 13:18
@andreas-el andreas-el force-pushed the coverage_gui_race_condition branch from c1476b2 to 1610a6d Compare September 18, 2023 13:40
@andreas-el andreas-el changed the title Revert "Fix a race condition in rft_csv_export test" Skip test_rft_csv_export_plugin_exports_rft_data Sep 18, 2023
@andreas-el andreas-el added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Sep 18, 2023
@andreas-el andreas-el self-assigned this Sep 18, 2023
@dafeda dafeda merged commit 1c6e2b8 into equinor:main Sep 18, 2023
40 checks passed
@andreas-el andreas-el deleted the coverage_gui_race_condition branch September 18, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants