Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where duplicate dates in summary caused update to crash #6014

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

oyvindeide
Copy link
Collaborator

We drop all duplicate time steps from the summary dates, and only read the first one.

Issue
Resolves #5967

Approach
Short description of the approach

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Wait for tests in CI to pass (see "checks" below)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured new behaviour is tested (opened GUI? screenshots? tried workflows?)
  • Commit history is consistent and clean, in line with the contribution guidelines.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution
    guidelines
    .

Copy link
Contributor

@dafeda dafeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable 👍

@oyvindeide oyvindeide force-pushed the fix_duplicate branch 2 times, most recently from 1cfbf94 to a7c48fb Compare September 20, 2023 07:17
@codecov-commenter
Copy link

Codecov Report

Merging #6014 (a7c48fb) into main (61ec478) will decrease coverage by 0.05%.
Report is 5 commits behind head on main.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##             main    #6014      +/-   ##
==========================================
- Coverage   82.49%   82.44%   -0.05%     
==========================================
  Files         350      350              
  Lines       21486    21444      -42     
  Branches      826      837      +11     
==========================================
- Hits        17725    17680      -45     
+ Misses       3467     3466       -1     
- Partials      294      298       +4     
Files Changed Coverage Δ
src/clib/lib/enkf/read_summary.cpp 0.00% <0.00%> (ø)
src/ert/config/summary_config.py 100.00% <100.00%> (ø)

... and 14 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oyvindeide oyvindeide merged commit 8a15332 into equinor:main Sep 21, 2023
@oyvindeide oyvindeide deleted the fix_duplicate branch January 25, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check how ert behaves when there are duplicate dates in summary files
4 participants