Fix inconsistent codecov reports #3452
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eivindjahren
force-pushed
the
better_codecov
branch
3 times, most recently
from
edd77ce to
9b8d960
Compare
As per codecov/codecov-bash#83 codecov has issues with github actions triggered by pullrequest. To remedy the situation, we use push as a trigger instead.
eivindjahren
force-pushed
the
better_codecov
branch
2 times, most recently
from
30f5425 to
1773fc7
Compare
eivindjahren
changed the title
Codecov Report
@@ Coverage Diff @@
## main #3452 +/- ##
==========================================
+ Coverage 65.35% 65.49% +0.13%
==========================================
Files 603 601 -2
Lines 47725 45321 -2404
Branches 4225 3775 -450
==========================================
- Hits 31191 29681 -1510
+ Misses 15171 14331 -840
+ Partials 1363 1309 -54
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
eivindjahren
force-pushed
the
better_codecov
branch
2 times, most recently
from
bcaefbe to
efc1894
Compare
Uses the --coverage option as a short-hand for -fprofile-arcs -ftest-coverage. Adds -fPIC and removes optimization in order to get more accurate coverage. Also, does not add -Wall when COVERAGE=ON as that is an unintended side-effect.
Added gcovr config which excludes partial info from branches that are not usually considered.
eivindjahren
force-pushed
the
better_codecov
branch
from
efc1894 to
ef33abd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The codecov report is currently not easy to understand and sometimes misleading. This seems to be due to a combination of factors:
To remedy the situation, the coverage reports are now run in a separate workflow, which is triggered by push and not pull request and only run on ubuntu. Also, gcovr is set to count more partial coverage as full coverage if the kind of branch is not of interest.
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.