Skip to content

Commit

Permalink
Address more review comments from ejah
Browse files Browse the repository at this point in the history
  • Loading branch information
berland committed Jan 2, 2025
1 parent 6cf0d50 commit d04533b
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions tests/ert/unit_tests/resources/test_run_eclipse_simulator.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,6 @@ def test_ecl100_binary_can_handle_extra_dots_in_casename(source_root):
@pytest.mark.requires_eclipse
@pytest.mark.usefixtures("use_tmpdir", "e100_env")
def test_run_reservoirsimulator_argparse_api(source_root):
# Todo: avoid actually running Eclipse here, use a mock
# Also test the other command line options.
shutil.copy(
source_root / "test-data/ert/eclipse/EIGHTCELLS.DATA",
"EIGHTCELLS.DATA",
Expand Down Expand Up @@ -126,7 +124,7 @@ def test_run_reservorsimulator_on_parallel_deck(source_root):
@pytest.mark.integration_test
@pytest.mark.requires_eclipse
@pytest.mark.usefixtures("use_tmpdir", "e100_env")
def test_run_reservoirsimulator_when_unsmry_is_ambiguous(source_root):
def test_run_reservoirsimulator_ignores_unrelated_summary_files(source_root):
shutil.copy(
source_root / "test-data/ert/eclipse/EIGHTCELLS.DATA",
"EIGHTCELLS.DATA",
Expand Down Expand Up @@ -159,7 +157,7 @@ def test_run_reservoirsimulator_when_unsmry_is_ambiguous_with_mpi(source_root):
@pytest.mark.integration_test
@pytest.mark.requires_eclipse
@pytest.mark.usefixtures("use_tmpdir", "e100_env")
def test_run_reservoirsimulator_on_nosim(source_root):
def test_run_reservoirsimulator_reports_successful_runs_with_nosim(source_root):
deck = (source_root / "test-data/ert/eclipse/EIGHTCELLS.DATA").read_text(
encoding="utf-8"
)
Expand Down Expand Up @@ -269,7 +267,7 @@ def test_failed_run_gives_nonzero_returncode_and_exception(monkeypatch):
@pytest.mark.integration_test
@pytest.mark.requires_eclipse
@pytest.mark.usefixtures("use_tmpdir", "e100_env")
def test_deck_errors_can_be_ignored(source_root):
def test_run_reservoirsimulator_ignores_errors_in_deck_when_requested(source_root):
shutil.copy(
source_root / "test-data/ert/eclipse/SPE1_ERROR.DATA",
"SPE1_ERROR.DATA",
Expand Down

0 comments on commit d04533b

Please sign in to comment.