Skip to content

Commit

Permalink
Fix test ensemble legacy
Browse files Browse the repository at this point in the history
  • Loading branch information
xjules committed Nov 20, 2024
1 parent bc2b82d commit 7991bbd
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 6 deletions.
1 change: 0 additions & 1 deletion docs/ert/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@
("py:class", "pydantic.types.PositiveInt"),
("py:class", "LibresFacade"),
("py:class", "pandas.core.frame.DataFrame"),
("py:class", "websockets.server.WebSocketServerProtocol"),
("py:class", "EnsembleReader"),
]
nitpick_ignore_regex = [
Expand Down
2 changes: 0 additions & 2 deletions src/ert/ensemble_evaluator/evaluator.py
Original file line number Diff line number Diff line change
Expand Up @@ -269,8 +269,6 @@ async def listen_for_messages(self) -> None:
await self.forward_checksum(event)
else:
await self._events.put(event)
# if type(event) in [EnsembleSucceeded, EnsembleFailed]:
# return
else:
logger.info(f"Connection attempt to unknown sender: {sender}.")
except zmq.error.ZMQError as e:
Expand Down
1 change: 0 additions & 1 deletion src/ert/ensemble_evaluator/monitor.py
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,6 @@ async def _receiver(self) -> None:
except zmq.ZMQError as exc:
logger.error(f"Failed to connect to {self._ee_con_info.router_uri} {exc}")
raise

await self._socket.send_multipart([b"", b"CONNECT"])
self._connected.set()

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ async def test_run_legacy_ensemble(
)
async with (
evaluator_to_use(ensemble, config) as evaluator,
Monitor(config) as monitor,
Monitor(config.get_connection_info()) as monitor,
):
async for event in monitor.track():
if type(event) in (
Expand Down Expand Up @@ -85,7 +85,7 @@ async def test_run_and_cancel_legacy_ensemble(

async with (
evaluator_to_use(ensemble, config) as evaluator,
Monitor(config) as monitor,
Monitor(config.get_connection_info()) as monitor,
):
# on lesser hardware the realizations might be killed by max_runtime
# and the ensemble is set to STOPPED
Expand Down

0 comments on commit 7991bbd

Please sign in to comment.