Adds teardown to avoid flaky tests with run_dialog

equinor · Nov 25, 2024 · 3a8ffd8 · 3a8ffd8
1 parent bd0538e
commit 3a8ffd8
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/tests/ert/unit_tests/gui/simulation/test_run_dialog.py b/tests/ert/unit_tests/gui/simulation/test_run_dialog.py
@@ -66,7 +66,10 @@ def notifier():
 def run_dialog(qtbot: QtBot, run_model, event_queue, notifier):
     run_dialog = RunDialog("mock.ert", run_model, event_queue, notifier)
     qtbot.addWidget(run_dialog)
-    return run_dialog
+
+    # Teardown
+    yield run_dialog
+    run_dialog.close()
 
 
 def test_terminating_experiment_shows_a_confirmation_dialog(
@@ -102,7 +105,6 @@ def test_run_dialog_polls_run_model_for_runtime(
     )
     event_queue.put(EndEvent(failed=False, msg=""))
     qtbot.waitUntil(lambda: run_dialog.is_simulation_done() == True)
-    run_dialog.close()
 
 
 def test_large_snapshot(
@@ -590,7 +592,6 @@ def handle_error_dialog(run_dialog):
 
         QTimer.singleShot(100, lambda: handle_error_dialog(run_dialog))
         qtbot.waitUntil(lambda: run_dialog.is_simulation_done() == True, timeout=100000)
-        run_dialog.close()
 
 
 @pytest.mark.integration_test