Skip to content

Commit

Permalink
Fix flakiness unit_tests/gui timeout
Browse files Browse the repository at this point in the history
Improves flakiness of unit_tests/gui/test_main_window::test_that_run_dialog_can_be_closed_after_used_to_open_plots by increasing timeout time for done_button to be enabled. This also applies to unit_tests/gui/simulation/test_run_dialog.py::test_that_run_dialog_can_be_closed_while_file_plot_is_open. In a different fixture, the timeout for running the experiment is set to 200.000, while here it was only 20.000. This commit increases this timeout to 200.000.
  • Loading branch information
jonathan-eq committed Feb 1, 2024
1 parent 027c80d commit 36d0b32
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion tests/unit_tests/gui/simulation/test_run_dialog.py
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ def handle_dialog():
qtbot.mouseClick(run_dialog.show_details_button, Qt.LeftButton)
job_view = run_dialog._job_view
qtbot.waitUntil(job_view.isVisible, timeout=20000)
qtbot.waitUntil(run_dialog.done_button.isVisible, timeout=20000)
qtbot.waitUntil(run_dialog.done_button.isVisible, timeout=200000)

realization_widget = run_dialog.findChild(RealizationWidget)

Expand Down
2 changes: 1 addition & 1 deletion tests/unit_tests/gui/test_main_window.py
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ def handle_dialog():
assert not run_dialog.isModal()

qtbot.mouseClick(run_dialog.plot_button, Qt.LeftButton)
qtbot.waitUntil(run_dialog.done_button.isVisible, timeout=20000)
qtbot.waitUntil(run_dialog.done_button.isVisible, timeout=200000)
qtbot.mouseClick(run_dialog.done_button, Qt.LeftButton)

# Ensure that once the run dialog is closed
Expand Down

0 comments on commit 36d0b32

Please sign in to comment.