Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: migration guide ecalc 9.6 #766

Merged
merged 4 commits into from
Jan 16, 2025
Merged

docs: migration guide ecalc 9.6 #766

merged 4 commits into from
Jan 16, 2025

Conversation

TeeeJay
Copy link
Collaborator

@TeeeJay TeeeJay commented Jan 16, 2025

Have you remembered and considered?

  • I have remembered to update documentation
  • I have remembered to update manual changelog (docs/drafts/next.draft.md)
  • I have remembered to update migration guide (docs/docs/migration_guides/)
  • I have committed with BREAKING: in footer or ! in header, if breaking
  • I have added tests (if not, comment why)
  • I have used conventional commits syntax (if you squash, make sure that conventional commit is used)
  • I have included the Jira issue ID somewhere in the commit body (ECALC-XXXX)

Why is this pull request needed?

This pull request is needed because of....

What does this pull request change?

Write summary of what this pull request changes if needed.

Issues related to this change:

@TeeeJay TeeeJay requested a review from a team as a code owner January 16, 2025 09:47
Comment on lines 19 to 20
* Fixed a bug where electrical consumers were allowed to have duplicate names. Also the following elements must also
have duplicate names: `MODELS`, `FACILITY_INPUT`, `TIME_SERIES`, `FUEL_TYPES` and `EMISSIONS` names.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unique instead of duplicate names?

@TeeeJay TeeeJay requested a review from a team as a code owner January 16, 2025 10:07
@TeeeJay TeeeJay merged commit ebd27e7 into main Jan 16, 2025
8 checks passed
@TeeeJay TeeeJay deleted the migration_guide_9_6 branch January 16, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants