🧑💻add 'use client' to relevant index files #3716
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This did not work, we'll leave this for a bit while @sebastianvitterso does some more research |
|
I opened an issue in the Nextjs repo vercel/next.js#74585 so they can help. Seems to be a very strange edge-case we're hitting here. |
|
For reference, @sebastianvitterso found this article explaining the issue at hand. So to fully support ssr we would need to either change to the pattern descibed in this article (big breaking change) or make the subcomponents available for import individually (maybe ideally imported from a sub-path and not root directly to avoid chaos) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3702
it was reported that 'use client' on the main index file did not "inherit" down to sub-components. This pr adds 'use client' to the index of components with sub-components. I don't have a test setup to check if this works so I'll make a dev release for @sebastianvitterso to check