-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Improve data grid #3231
✨ Improve data grid #3231
Conversation
This is neccessary because EDS uses React Context and the grid and the project should have the same React instance running. This makes it possible to set EDS Density of the table above the component.
…content This enables custom cells like popover, autocomplete or other cells that overflows the cell itself.
This ensures hover color on the whole row
This is needed to be able to run "scroll to" functionality in apps.
I cannot edit reviewers, but I would like a review from @yusijs 😄 It seems like the checks are failing due to a missing secret, but I'm not sure whether it's on my side or yours? |
I have added @yusijs as a reviewer 🙂 |
Great, thank you! |
✅ Lint |
Lint, test and build is all ✅ on my side, but you might want to check again on you end @oddvernes after the last changes? |
lint/test/types all seems to be in order still 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Yes I will merge 👍 Was just trying the build downstream in an app for the final test but looks good |
resolves #3234
What does this pull request change?
This pull request introduces the following improvements to the data-grid:
Most of these changes have been discussed with @yusijs.
@tanstack/react-table
types to ease typing in apps using the data gridhave the same React instance running. This makes it possible to set EDS Density of the
table above the component.
width
andheight
Why is this pull request needed?
In order to implement this in our project, we need to be able to use custom cells, set 100% width and use the EdsProvider with the table. Also, there are some minor bugs discovered during implementation.