Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update notifications on fabric connections resource #837

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

thogarty
Copy link
Contributor

@thogarty thogarty commented Jan 7, 2025

  • Allow modification of the notification attribute in the fabric connection resource

d-bhola
d-bhola previously approved these changes Jan 7, 2025
Copy link
Contributor

@d-bhola d-bhola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@d-bhola
Copy link
Contributor

d-bhola commented Jan 7, 2025

There are some linting failures that need to be fixed.

@thogarty thogarty merged commit fa46d24 into main Jan 7, 2025
9 of 12 checks passed
@thogarty thogarty deleted the fabric_connection_update_method_improvements branch January 7, 2025 21:56
Copy link

github-actions bot commented Jan 7, 2025

This PR is included in version 3.1.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants