-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Updating Service Token Resource for network based token #833
Conversation
srushti-patl
commented
Dec 18, 2024
- Updated Service Token Resource Schema and Model
- Updated docs for Service Token to add zside Network based token
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With recent change (for Feb release) https://github.com/equinix-product/interconnection_fabric-api-model/pull/1000#pullrequestreview-2518132243, the connection.type
is not mandatory anymore. Should we revise models.go
accordingly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Large PR; I've added the notes for what I was able to see in the first pass. Will review again once we've resolved open discussions.
Please respond to Ryan Li's comment on this PR as well. Could be useful to include that change here as well.
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #833 +/- ##
==========================================
- Coverage 36.13% 32.17% -3.96%
==========================================
Files 184 184
Lines 24491 24606 +115
==========================================
- Hits 8850 7918 -932
- Misses 15480 16624 +1144
+ Partials 161 64 -97 ☔ View full report in Codecov by Sentry. |
Confirmed with Ryan that we will change the connection type parameter to optional after the February release. Those changes are not in production right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change. The mapping method is critical because it's what's being set to state. It's a good hub to check whenever the plan is showing differences. Very closely related to attribute behaviors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Ship it.
This PR is included in version 3.1.0 🎉 |