Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updating Service Token Resource for network based token #833

Merged
merged 6 commits into from
Dec 23, 2024

Conversation

srushti-patl
Copy link
Contributor

  • Updated Service Token Resource Schema and Model
  • Updated docs for Service Token to add zside Network based token

@srushti-patl srushti-patl requested a review from a team as a code owner December 18, 2024 18:04
@srushti-patl srushti-patl changed the title CXF 104039 Updating Service Token Resource for network based token feat: Updating Service Token Resource for network based token Dec 18, 2024
Copy link

@ryli17 ryli17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With recent change (for Feb release) https://github.com/equinix-product/interconnection_fabric-api-model/pull/1000#pullrequestreview-2518132243, the connection.type is not mandatory anymore. Should we revise models.go accordingly?

Copy link
Contributor

@thogarty thogarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Large PR; I've added the notes for what I was able to see in the first pass. Will review again once we've resolved open discussions.

Please respond to Ryan Li's comment on this PR as well. Could be useful to include that change here as well.

internal/resources/fabric/service_token/models.go Outdated Show resolved Hide resolved
internal/resources/fabric/service_token/models.go Outdated Show resolved Hide resolved
internal/resources/fabric/service_token/resource.go Outdated Show resolved Hide resolved
internal/resources/fabric/service_token/models.go Outdated Show resolved Hide resolved
internal/resources/fabric/service_token/models.go Outdated Show resolved Hide resolved
internal/resources/fabric/service_token/models.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 15.03268% with 130 lines in your changes missing coverage. Please review.

Project coverage is 32.17%. Comparing base (c71308e) to head (53091c3).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
internal/resources/fabric/service_token/models.go 19.13% 83 Missing and 10 partials ⚠️
...nternal/resources/fabric/service_token/resource.go 0.00% 37 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #833      +/-   ##
==========================================
- Coverage   36.13%   32.17%   -3.96%     
==========================================
  Files         184      184              
  Lines       24491    24606     +115     
==========================================
- Hits         8850     7918     -932     
- Misses      15480    16624    +1144     
+ Partials      161       64      -97     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ryli17
ryli17 previously approved these changes Dec 23, 2024
@srushti-patl
Copy link
Contributor Author

With recent change (for Feb release) equinix-product/interconnection_fabric-api-model#1000 (review), the connection.type is not mandatory anymore. Should we revise models.go accordingly?

Confirmed with Ryan that we will change the connection type parameter to optional after the February release. Those changes are not in production right now.

Copy link
Contributor

@thogarty thogarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change. The mapping method is critical because it's what's being set to state. It's a good hub to check whenever the plan is showing differences. Very closely related to attribute behaviors.

internal/resources/fabric/service_token/models.go Outdated Show resolved Hide resolved
Copy link
Contributor

@thogarty thogarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ship it.

@srushti-patl srushti-patl merged commit 673e6d8 into main Dec 23, 2024
9 of 12 checks passed
@srushti-patl srushti-patl deleted the CXF-104039-Network-Service-Token branch December 23, 2024 22:44
Copy link

This PR is included in version 3.1.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants