Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create device without default password(supported for only C8000V Autonomous and Fortinet firewall devices) #826

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

kpdhulipala
Copy link
Contributor

@kpdhulipala kpdhulipala commented Dec 3, 2024

feat: create device without default password(supported for only C8000V Autonomous and Fortinet firewall devices)

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 36.12%. Comparing base (c71308e) to head (de55d31).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
equinix/resource_network_device.go 25.00% 2 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #826      +/-   ##
==========================================
- Coverage   36.13%   36.12%   -0.02%     
==========================================
  Files         184      184              
  Lines       24491    24502      +11     
==========================================
+ Hits         8850     8851       +1     
- Misses      15480    15489       +9     
- Partials      161      162       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rling-equinix rling-equinix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@shyamchalla shyamchalla merged commit 54796c3 into equinix:main Dec 7, 2024
5 of 7 checks passed
Copy link

github-actions bot commented Dec 9, 2024

This PR is included in version 3.0.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants