Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Provide examples for create device types - ZSCALER APPC and PSE #819

Merged
merged 5 commits into from
Nov 16, 2024

Conversation

kpdhulipala
Copy link
Contributor

feat: Provide examples for create device types - ZSCALER APPC and PSE

@kpdhulipala kpdhulipala requested a review from a team as a code owner November 15, 2024 21:59
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.13%. Comparing base (3623385) to head (c254e69).
Report is 58 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #819      +/-   ##
==========================================
+ Coverage   35.87%   36.13%   +0.26%     
==========================================
  Files         179      184       +5     
  Lines       23191    24491    +1300     
==========================================
+ Hits         8319     8850     +531     
- Misses      14711    15480     +769     
  Partials      161      161              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@displague displague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Not sure we need the _account datasourc e to get the metro code, but it doesn't hurt.

@shyamchalla shyamchalla merged commit c71308e into equinix:main Nov 16, 2024
5 checks passed
Copy link

This PR is included in version 2.11.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants