Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding Zside Port Service Token resource #817

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

srushti-patl
Copy link
Contributor

-Added Zside Port Service Token Resource Acc Tests

  • Updated docs for Service Token Resource

Copy link
Contributor

@thogarty thogarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure about how this is working based on naming conventions and contradictions.

docs/resources/fabric_service_token.md Show resolved Hide resolved
@@ -110,6 +110,53 @@ func TestAccFabricAsidePortServiceToken_PNFV(t *testing.T) {
})
}

func TestAccFabricZsidePortServiceToken_PNFV(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're adding tests for Zside, but then have documentation related to Aside. I'm confused how this is working.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the wrong name in the documentation. It's zside service token example. Apologize for the confusion.

Copy link
Contributor

@thogarty thogarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ship it.

@srushti-patl srushti-patl merged commit 242d3bf into main Nov 19, 2024
9 of 12 checks passed
@srushti-patl srushti-patl deleted the CXF-104038-Zside-Port-Service-Token-Resource branch November 19, 2024 17:40
Copy link

github-actions bot commented Dec 9, 2024

This PR is included in version 3.0.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants