Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fabric resource connection_route_filter #795

Merged
merged 7 commits into from
Oct 14, 2024
Merged

Conversation

thogarty
Copy link
Contributor

@thogarty thogarty commented Oct 8, 2024

  • Add equinix_fabric_connection_route_filter resource to attach route filter policies to fabric cloud router connections
  • Add data source for retrieving connection_route_filters by connection and route filter uuids
  • Add data source to get all route filters for a given connection uuid
  • Add docs with make docs
  • Add acceptance tests for resource and data sources

Local tests passing:
image

@thogarty thogarty added the area/resources/fabric Issues related to Fabric and ECX APIs label Oct 8, 2024
@thogarty thogarty requested review from a team as code owners October 8, 2024 20:52
Copy link
Member

@displague displague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provider.go changes look good

@thogarty thogarty force-pushed the connection_route_filter branch from 0cccad0 to 209a358 Compare October 14, 2024 19:25
@thogarty thogarty merged commit 343c8fc into main Oct 14, 2024
8 of 11 checks passed
@thogarty thogarty deleted the connection_route_filter branch October 14, 2024 19:27
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 51.37845% with 194 lines in your changes missing coverage. Please review.

Project coverage is 38.83%. Comparing base (4b6af14) to head (209a358).
Report is 54 commits behind head on main.

Files with missing lines Patch % Lines
...sources/fabric/connection_route_filter/resource.go 14.76% 127 Missing ⚠️
...resources/fabric/connection_route_filter/models.go 0.00% 51 Missing ⚠️
...rces/fabric/connection_route_filter/datasources.go 55.55% 16 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #795      +/-   ##
==========================================
+ Coverage   34.38%   38.83%   +4.44%     
==========================================
  Files         154      173      +19     
  Lines       21080    23136    +2056     
==========================================
+ Hits         7249     8985    +1736     
- Misses      13670    13941     +271     
- Partials      161      210      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

srushti-patl pushed a commit that referenced this pull request Oct 28, 2024
* Add equinix_fabric_connection_route_filter resource to attach route
filter policies to fabric cloud router connections
* Add data source for retrieving connection_route_filters by connection
and route filter uuids
* Add data source to get all route filters for a given connection uuid
* Add docs with make docs
* Add acceptance tests for resource and data sources

Local tests passing:
<img width="1278" alt="image"
src="https://github.com/user-attachments/assets/bbf2f520-5219-440a-944c-59aaf7b24278">
srushti-patl pushed a commit that referenced this pull request Oct 28, 2024
* Add equinix_fabric_connection_route_filter resource to attach route
filter policies to fabric cloud router connections
* Add data source for retrieving connection_route_filters by connection
and route filter uuids
* Add data source to get all route filters for a given connection uuid
* Add docs with make docs
* Add acceptance tests for resource and data sources

Local tests passing:
<img width="1278" alt="image"
src="https://github.com/user-attachments/assets/bbf2f520-5219-440a-944c-59aaf7b24278">
srushti-patl pushed a commit that referenced this pull request Oct 28, 2024
* Add equinix_fabric_connection_route_filter resource to attach route
filter policies to fabric cloud router connections
* Add data source for retrieving connection_route_filters by connection
and route filter uuids
* Add data source to get all route filters for a given connection uuid
* Add docs with make docs
* Add acceptance tests for resource and data sources

Local tests passing:
<img width="1278" alt="image"
src="https://github.com/user-attachments/assets/bbf2f520-5219-440a-944c-59aaf7b24278">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/resources/fabric Issues related to Fabric and ECX APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants