Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add optional attribute tier in Create Virtual Device request for C8000V and C8000V SDWAN #771

Merged
merged 4 commits into from
Oct 23, 2024
Merged

feat: Add optional attribute tier in Create Virtual Device request for C8000V and C8000V SDWAN #771

merged 4 commits into from
Oct 23, 2024

Conversation

kpdhulipala
Copy link
Contributor

feat: Add optional attribute tier in Create Virtual Device request for C8000V and C8000V SDWAN

@kpdhulipala kpdhulipala requested review from a team as code owners September 9, 2024 16:31
@kpdhulipala kpdhulipala marked this pull request as draft September 9, 2024 16:35
rling-equinix
rling-equinix requested changes Sep 10, 2024
View reviewed changes
docs/resources/network_device.md Outdated Show resolved Hide resolved
equinix/resource_network_device.go Outdated Show resolved Hide resolved
equinix/resource_network_device.go Outdated Show resolved Hide resolved
templates/resources/network_device.md.tmpl Outdated Show resolved Hide resolved
equinix/resource_network_device.go Outdated Show resolved Hide resolved
@kpdhulipala kpdhulipala force-pushed the NFV-29480 branch 7 times, most recently from fc8577d to dc51985 Compare September 12, 2024 02:35
@kpdhulipala kpdhulipala marked this pull request as ready for review September 12, 2024 02:36
@ctreatma
Copy link
Contributor

A unit test is failing:

=== RUN   TestNetworkDevice_updateResourceData
    resource_network_device_test.go:141: 
        	Error Trace:	/home/runner/work/terraform-provider-equinix/terraform-provider-equinix/equinix/resource_network_device_test.go:141
        	Error:      	Expected nil, but got: &errors.errorString{s:"error reading Secondary: Invalid address to set: []string{\"secondary_device\", \"0\", \"tier\"}"}
        	Test:       	TestNetworkDevice_updateResourceData
        	Messages:   	Update of resource data does not return error
--- FAIL: TestNetworkDevice_updateResourceData (0.00s)

rling-equinix
rling-equinix approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@rling-equinix rling-equinix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@kpdhulipala kpdhulipala merged commit f59c2f9 into equinix:main Oct 23, 2024
4 of 6 checks passed
srushti-patl pushed a commit that referenced this pull request Oct 28, 2024
@kpdhulipala @srushti-patl
feat: Add optional attribute tier in Create Virtual Device request fo…
1805f8d 
…r C8000V and C8000V SDWAN (#771)

feat: Add optional attribute tier in Create Virtual Device request for
C8000V and C8000V SDWAN
srushti-patl pushed a commit that referenced this pull request Oct 28, 2024
@kpdhulipala @srushti-patl
feat: Add optional attribute tier in Create Virtual Device request fo…
83f3bd1 
…r C8000V and C8000V SDWAN (#771)

feat: Add optional attribute tier in Create Virtual Device request for
C8000V and C8000V SDWAN
srushti-patl pushed a commit that referenced this pull request Oct 28, 2024
@kpdhulipala @srushti-patl
feat: Add optional attribute tier in Create Virtual Device request fo…
4f91dcb 
…r C8000V and C8000V SDWAN (#771)

feat: Add optional attribute tier in Create Virtual Device request for
C8000V and C8000V SDWAN
@github-actions GitHub Actions
Copy link

This PR is included in version 2.10.0 🎉

@github-actions GitHub Actions
Copy link

This PR is included in version 2.11.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shyamchalla shyamchalla shyamchalla approved these changes

@rling-equinix rling-equinix rling-equinix approved these changes

@ctreatma ctreatma ctreatma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kpdhulipala @codecov-commenter @ctreatma @rling-equinix @shyamchalla