-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixing METAL NIMF docs #749
Conversation
} | ||
data "equinix_fabric_service_profiles" "zside" { | ||
count = var.zside_ap_type == "SP" ? 1 : 0 | ||
count = local.zside_ap_type == "SP" ? 1 : 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This condition causes the example to fail when converting to Pulumi and does not provide any value here as this example is just for connecting to a service provider. It would be helpful if you removed the count
here. This update will also require updating the line referencing it uuid = data.equinix_fabric_service_profiles.zside[0].id
with uuid = data.equinix_fabric_service_profiles.zside.id
.
LGTM but I'm going to leave it to @ocobles to submit an official review for the Metal parts of this PR since he has a better idea of what needs to be done here. |
@equinix/governor-digin-fabric this has been approved from a DRE perspective; just requires review and approval from your team before it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This PR is included in version 2.3.2 🎉 |
Fixing Metal-NIMF doc examples
Reference: #744