Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixing METAL NIMF docs #749

Merged
merged 5 commits into from
Aug 9, 2024
Merged

fix: Fixing METAL NIMF docs #749

merged 5 commits into from
Aug 9, 2024

Conversation

srushti-patl
Copy link
Contributor

Fixing Metal-NIMF doc examples
Reference: #744

@srushti-patl srushti-patl requested a review from a team as a code owner August 5, 2024 18:12
@srushti-patl srushti-patl marked this pull request as draft August 5, 2024 18:14
@srushti-patl srushti-patl marked this pull request as ready for review August 5, 2024 18:15
@ocobles ocobles self-assigned this Aug 6, 2024
}
data "equinix_fabric_service_profiles" "zside" {
count = var.zside_ap_type == "SP" ? 1 : 0
count = local.zside_ap_type == "SP" ? 1 : 0
Copy link
Contributor

@ocobles ocobles Aug 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This condition causes the example to fail when converting to Pulumi and does not provide any value here as this example is just for connecting to a service provider. It would be helpful if you removed the count here. This update will also require updating the line referencing it uuid = data.equinix_fabric_service_profiles.zside[0].id with uuid = data.equinix_fabric_service_profiles.zside.id.

@ctreatma
Copy link
Contributor

ctreatma commented Aug 7, 2024

LGTM but I'm going to leave it to @ocobles to submit an official review for the Metal parts of this PR since he has a better idea of what needs to be done here.

@ctreatma
Copy link
Contributor

ctreatma commented Aug 8, 2024

@equinix/governor-digin-fabric this has been approved from a DRE perspective; just requires review and approval from your team before it can be merged.

Copy link
Contributor

@thogarty thogarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@srushti-patl srushti-patl merged commit 59af0b3 into main Aug 9, 2024
8 of 11 checks passed
@srushti-patl srushti-patl deleted the metal-NIMF-doc-fix branch August 9, 2024 17:05
Copy link

This PR is included in version 2.3.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants