refactor: move device resource and datasource to separate package #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
displague
reviewed
Jun 28, 2024
ctreatma
force-pushed
the
metal-device-package
branch
from
36c686a to
5890747
Compare
ctreatma
force-pushed
the
metal-device-package
branch
from
5890747 to
1b060e5
Compare
displague
previously approved these changes
Jul 10, 2024
ctreatma
force-pushed
the
metal-device-package
branch
from
1b060e5 to
d8283fb
Compare
displague
reviewed
Jul 10, 2024
ctreatma
force-pushed
the
metal-device-package
branch
from
d8283fb to
4f403c8
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #707 +/- ##
===========================================
+ Coverage 34.44% 51.89% +17.45%
===========================================
Files 151 152 +1
Lines 20710 20922 +212
===========================================
+ Hits 7133 10857 +3724
+ Misses 13415 9630 -3785
- Partials 162 435 +273 ☔ View full report in Codecov by Sentry. |
ctreatma
force-pushed
the
metal-device-package
branch
from
d698e10 to
bd10c8e
Compare
ctreatma
force-pushed
the
metal-device-package
branch
from
bd10c8e to
3e46717
Compare
ctreatma
force-pushed
the
metal-device-package
branch
from
3e46717 to
02f8c71
Compare
ctreatma
force-pushed
the
metal-device-package
branch
from
02f8c71 to
ca33274
Compare
ctreatma
force-pushed
the
metal-device-package
branch
from
ca33274 to
fddfc02
Compare
displague
approved these changes
Sep 25, 2024
|
This PR is included in version 2.6.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the device resource and data sources out of the
equinixpackage and into an isolated directory & package to align with #106.