-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate resource and datasource equinix_metal_project to framework #604
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #604 +/- ##
===========================================
+ Coverage 39.04% 61.29% +22.25%
===========================================
Files 114 120 +6
Lines 19186 19393 +207
===========================================
+ Hits 7491 11887 +4396
+ Misses 11489 6923 -4566
- Partials 206 583 +377 ☔ View full report in Codecov by Sentry. |
215ceba
to
b6abead
Compare
74cfb59
to
3217d4a
Compare
Signed-off-by: ocobleseqx <[email protected]>
Signed-off-by: ocobleseqx <[email protected]>
Signed-off-by: ocobleseqx <[email protected]>
…se fw provider Signed-off-by: ocobleseqx <[email protected]>
Signed-off-by: ocobleseqx <[email protected]>
Signed-off-by: ocobleseqx <[email protected]>
Signed-off-by: ocobleseqx <[email protected]>
Signed-off-by: ocobleseqx <[email protected]>
…n ExternalProvider Signed-off-by: ocobleseqx <[email protected]>
Signed-off-by: ocobleseqx <[email protected]>
…rce a new resource Signed-off-by: ocobleseqx <[email protected]>
Co-authored-by: Charles Treatman <[email protected]> Signed-off-by: Óscar Cobles <[email protected]>
Signed-off-by: ocobleseqx <[email protected]>
Signed-off-by: ocobleseqx <[email protected]>
Signed-off-by: ocobleseqx <[email protected]>
Signed-off-by: ocobleseqx <[email protected]>
Signed-off-by: ocobleseqx <[email protected]>
3217d4a
to
ec85ea8
Compare
The BGP update test was still failing because the project was being deleted and recreated. After some digging I found it was because I updated the schema to add the missing plan modifier and updated the error message in the immutable list to match the existing test expectation: 30e64cc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran CI twice and observed no failures in project resource / datasource tests and a couple flakes in unrelated tests.
Part of #612