-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate resource metal_organization_member to framework #588
Conversation
internal/resources/metal/organization_member/resource_schema.go
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #588 +/- ##
==========================================
- Coverage 40.31% 39.89% -0.43%
==========================================
Files 107 109 +2
Lines 18793 18977 +184
==========================================
- Hits 7577 7570 -7
- Misses 11010 11202 +192
+ Partials 206 205 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a number of places where errors are being dropped instead of added to resp.Diagnostics. I've noted them in comments but I may have missed some. It's possible the test failure is happening because of one of these dropped errors.
Tests were failing because the framework resource was attempting to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the project IDs fix, the only 2 test failures in the latest CI run are in unrelated tests for IP attachment and spot market.
Part of #612