Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate resource metal_organization_member to framework #588

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

codinja1188
Copy link
Contributor

@codinja1188 codinja1188 commented Feb 23, 2024

Part of #612

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 345 lines in your changes are missing coverage. Please review.

Project coverage is 39.89%. Comparing base (5cb18ad) to head (5a947d4).

Files Patch % Lines
...al/resources/metal/organization_member/resource.go 0.00% 240 Missing ⚠️
...urces/metal/organization_member/resource_schema.go 0.00% 57 Missing ⚠️
...rnal/resources/metal/organization_member/models.go 0.00% 48 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #588      +/-   ##
==========================================
- Coverage   40.31%   39.89%   -0.43%     
==========================================
  Files         107      109       +2     
  Lines       18793    18977     +184     
==========================================
- Hits         7577     7570       -7     
- Misses      11010    11202     +192     
+ Partials      206      205       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codinja1188 codinja1188 requested a deployment to external March 18, 2024 21:49 — with GitHub Actions Abandoned
Copy link
Contributor

@ctreatma ctreatma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a number of places where errors are being dropped instead of added to resp.Diagnostics. I've noted them in comments but I may have missed some. It's possible the test failure is happening because of one of these dropped errors.

@ctreatma
Copy link
Contributor

Tests were failing because the framework resource was attempting to use Href objects as strings. I copied the code from the SDK resource that builds string arrays of project IDs: 5a947d4

Copy link
Contributor

@ctreatma ctreatma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the project IDs fix, the only 2 test failures in the latest CI run are in unrelated tests for IP attachment and spot market.

@ctreatma ctreatma merged commit e6d1b41 into equinix:main Mar 19, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants