refactor: update tests to use new standalone terraform-plugin-testing module #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… module Signed-off-by: ocobleseqx <[email protected]>
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #526 +/- ##
==========================================
- Coverage 60.11% 58.85% -1.27%
==========================================
Files 99 96 -3
Lines 20045 19857 -188
==========================================
- Hits 12051 11686 -365
- Misses 7691 7885 +194
+ Partials 303 286 -17 ☔ View full report in Codecov by Sentry. |
ctreatma
approved these changes
Jan 18, 2024
cprivitere
added a commit
that referenced
this pull request
Jan 18, 2024
#526 adopted the terraform-plugin-testing module, but #520 introduced a new test that had a reference to the old terraform-plugin-sdk version of that module. Since we don't have a requirement in place for PRs to be up-to-date before merging, #526 got merged without being updated to also fix the new test from #520, and as a result the `Go test` workflow started failing. This updates the new test to match the others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a go module was released last year to keep testing functionality separated from schema logic https://github.com/hashicorp/terraform-plugin-testing We need this replacement to use some functionality required to test migration from sdkv2 to framework, like plancheck https://developer.hashicorp.com/terraform/plugin/framework/migrating/testing#example
Keeping both github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource and github.com/hashicorp/terraform-plugin-testing/helper/resource imports produces a panic error #406 (comment) so it is required to fully replace all