Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate to plugin sdkv2 helper/id and helper/retry packages #524

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

ocobles
Copy link
Contributor

@ocobles ocobles commented Jan 18, 2024

Previous step to migrate testing functionality from github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource to github.com/hashicorp/terraform-plugin-testing/v2/helper/resource required to add e2e tests to migrate from SDKv2 to Framework #406 (comment)

Almost all resource.StateChangeConf references had already been previously migrated to retry.StateChangeConf

https://developer.hashicorp.com/terraform/plugin/testing/migrating

@codecov-commenter
Copy link

Codecov Report

Attention: 710 lines in your changes are missing coverage. Please review.

Comparison is base (26b2f3d) 60.11% compared to head (7e43bd1) 59.21%.
Report is 131 commits behind head on main.

Files Patch % Lines
internal/errors/errors.go 7.58% 134 Missing ⚠️
equinix/fabric_mapping_helper.go 0.00% 69 Missing ⚠️
equinix/resource_fabric_connection.go 0.00% 54 Missing ⚠️
equinix/resource_fabric_cloud_router.go 0.00% 46 Missing ⚠️
equinix/resource_network_device.go 2.50% 39 Missing ⚠️
equinix/resource_fabric_routing_protocol.go 0.00% 26 Missing ⚠️
equinix/resource_fabric_service_profile.go 0.00% 26 Missing ⚠️
internal/resources/metal/metal_ssh_key/resource.go 73.62% 19 Missing and 5 partials ⚠️
equinix/resource_metal_device.go 74.71% 18 Missing and 4 partials ⚠️
equinix/resource_metal_virtual_circuit.go 50.00% 13 Missing and 2 partials ⚠️
... and 44 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #524      +/-   ##
==========================================
- Coverage   60.11%   59.21%   -0.91%     
==========================================
  Files          99       96       -3     
  Lines       20045    19842     -203     
==========================================
- Hits        12051    11749     -302     
- Misses       7691     7802     +111     
+ Partials      303      291      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctreatma
Copy link
Contributor

Since this is touching some Fabric things, I think we should get eyes on it from someone in @equinix/governor-digin-fabric if only to spread awareness of the change.

@ocobles ocobles merged commit 939a319 into main Jan 18, 2024
5 of 6 checks passed
@ocobles ocobles deleted the replace-deprecated-resource-packages branch January 18, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants