Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fabric Docs #506

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Conversation

thogarty
Copy link
Contributor

@thogarty thogarty commented Jan 5, 2024

  • Added Example Usage to Fabric Resources/Data Sources
  • Add Migration Guide for ECX->Fabric Resources
  • Update deprecation notice for ECX resources
  • Remove Beta notice from Fabric V4 Resources

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

Attention: 525 lines in your changes are missing coverage. Please review.

Comparison is base (26b2f3d) 60.11% compared to head (0ece02b) 59.54%.
Report is 128 commits behind head on main.

Files Patch % Lines
equinix/fabric_mapping_helper.go 0.00% 68 Missing ⚠️
equinix/resource_fabric_connection.go 0.00% 52 Missing ⚠️
equinix/resource_fabric_cloud_router.go 0.00% 42 Missing ⚠️
equinix/resource_network_device.go 3.57% 27 Missing ⚠️
equinix/resource_metal_device.go 71.26% 21 Missing and 4 partials ⚠️
equinix/resource_fabric_service_profile.go 0.00% 24 Missing ⚠️
internal/resources/metal/metal_ssh_key/resource.go 73.62% 19 Missing and 5 partials ⚠️
equinix/resource_fabric_routing_protocol.go 0.00% 22 Missing ⚠️
equinix/resource_metal_virtual_circuit.go 50.00% 13 Missing and 2 partials ⚠️
equinix/resource_metal_organization_member.go 40.90% 13 Missing ⚠️
... and 41 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #506      +/-   ##
==========================================
- Coverage   60.11%   59.54%   -0.58%     
==========================================
  Files          99       95       -4     
  Lines       20045    19729     -316     
==========================================
- Hits        12051    11748     -303     
+ Misses       7691     7689       -2     
+ Partials      303      292      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -13,7 +13,13 @@ Fabric V4 API compatible data resource that allow user to fetch connection for a

~> **Note** Equinix Fabric v4 resources and datasources are currently in Beta. The interfaces related to `equinix_fabric_` resources and datasources may change ahead of general availability. Please, do not hesitate to report any problems that you experience by opening a new [issue](https://github.com/equinix/terraform-provider-equinix/issues/new?template=bug.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this beta notice be removed from these resources now or are there additional things that need to happen before the beta notice can be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok to remove it now. We're out of the beta cycle and they're actively maintained in GA. I've made the updates 👍

This PR should be good to go now.

Copy link
Contributor

@srushti-patl srushti-patl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thogarty thogarty merged commit f19bb88 into main Jan 12, 2024
5 of 6 checks passed
@thogarty thogarty deleted the CXF-76681-add-example-usage-to-fabric-docs branch January 12, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants