-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Fabric Docs #506
docs: Fabric Docs #506
Conversation
thogarty
commented
Jan 5, 2024
•
edited
Loading
edited
- Added Example Usage to Fabric Resources/Data Sources
- Add Migration Guide for ECX->Fabric Resources
- Update deprecation notice for ECX resources
- Remove Beta notice from Fabric V4 Resources
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #506 +/- ##
==========================================
- Coverage 60.11% 59.54% -0.58%
==========================================
Files 99 95 -4
Lines 20045 19729 -316
==========================================
- Hits 12051 11748 -303
+ Misses 7691 7689 -2
+ Partials 303 292 -11 ☔ View full report in Codecov by Sentry. |
@@ -13,7 +13,13 @@ Fabric V4 API compatible data resource that allow user to fetch connection for a | |||
|
|||
~> **Note** Equinix Fabric v4 resources and datasources are currently in Beta. The interfaces related to `equinix_fabric_` resources and datasources may change ahead of general availability. Please, do not hesitate to report any problems that you experience by opening a new [issue](https://github.com/equinix/terraform-provider-equinix/issues/new?template=bug.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this beta notice be removed from these resources now or are there additional things that need to happen before the beta notice can be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's ok to remove it now. We're out of the beta cycle and they're actively maintained in GA. I've made the updates 👍
This PR should be good to go now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!