Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add VM resizing for device resource core upgrade and new device status for device data source #492

Merged
merged 4 commits into from
Dec 15, 2023

Conversation

rling-equinix
Copy link
Contributor

@rling-equinix rling-equinix commented Dec 14, 2023

In Dec release, we added the "core" field to the Update Virtual Device API to allow users to resize their devices. After device is provisioned, the customer can send a PATCH request to upgrade its core number. The device will be marked as "RESOURCE_UPGRADE_IN_PROGRESS" and once the upgrade is done, the device status will be provisioned again.
More details could be found in our API documentation.
reference: https://developer.equinix.com/docs?page=/dev-docs/ne/overview
product reference: https://docs.equinix.com/en-us/Content/Interconnection/NE/user-guide/NE-VNF-resize.htm#UpgradeResourceSizeforClusterDeviceDeployment

@rling-equinix rling-equinix changed the title NFV-26618: add VM resizing for device resource core upgrade and new device status for device data source feat: add VM resizing for device resource core upgrade and new device status for device data source Dec 14, 2023
@rling-equinix
Copy link
Contributor Author

go.mod and go.sum needs to be updated after equinix/ne-go#26 (go client) is merged.

@codecov-commenter
Copy link

Codecov Report

Attention: 452 lines in your changes are missing coverage. Please review.

Comparison is base (26b2f3d) 60.11% compared to head (3101db6) 59.60%.
Report is 101 commits behind head on main.

Files Patch % Lines
equinix/fabric_mapping_helper.go 0.00% 68 Missing ⚠️
equinix/resource_fabric_connection.go 0.00% 52 Missing ⚠️
equinix/resource_fabric_cloud_router.go 0.00% 42 Missing ⚠️
equinix/resource_network_device.go 3.57% 27 Missing ⚠️
equinix/resource_fabric_service_profile.go 0.00% 24 Missing ⚠️
equinix/resource_fabric_routing_protocol.go 0.00% 22 Missing ⚠️
equinix/resource_metal_device.go 78.46% 10 Missing and 4 partials ⚠️
equinix/resource_metal_organization_member.go 40.90% 13 Missing ⚠️
equinix/resource_network_device_link.go 0.00% 10 Missing ⚠️
equinix/resource_metal_connection.go 60.86% 8 Missing and 1 partial ⚠️
... and 40 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #492      +/-   ##
==========================================
- Coverage   60.11%   59.60%   -0.52%     
==========================================
  Files          99       95       -4     
  Lines       20045    19780     -265     
==========================================
- Hits        12051    11789     -262     
- Misses       7691     7696       +5     
+ Partials      303      295       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctreatma ctreatma merged commit 4f505dd into equinix:main Dec 15, 2023
4 of 5 checks passed
ctreatma pushed a commit that referenced this pull request Jan 23, 2024
Add the missing core count device update back
The core count field was introduced in the following PR:
#492
Then it was deleted from this PR:
#509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants