Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: switch from metal-go to equinix-sdk-go #489

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Conversation

ctreatma
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2023

Codecov Report

Attention: 435 lines in your changes are missing coverage. Please review.

Comparison is base (26b2f3d) 60.11% compared to head (0549237) 59.70%.
Report is 100 commits behind head on main.

Files Patch % Lines
equinix/fabric_mapping_helper.go 0.00% 68 Missing ⚠️
equinix/resource_fabric_connection.go 0.00% 52 Missing ⚠️
equinix/resource_fabric_cloud_router.go 0.00% 42 Missing ⚠️
equinix/resource_fabric_service_profile.go 0.00% 24 Missing ⚠️
equinix/resource_fabric_routing_protocol.go 0.00% 22 Missing ⚠️
equinix/resource_metal_device.go 76.92% 12 Missing and 3 partials ⚠️
equinix/resource_metal_organization_member.go 40.90% 13 Missing ⚠️
equinix/resource_network_device_link.go 0.00% 10 Missing ⚠️
equinix/resource_metal_connection.go 60.86% 8 Missing and 1 partial ⚠️
equinix/resource_metal_vlan.go 43.75% 8 Missing and 1 partial ⚠️
... and 40 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #489      +/-   ##
==========================================
- Coverage   60.11%   59.70%   -0.42%     
==========================================
  Files          99       95       -4     
  Lines       20045    19762     -283     
==========================================
- Hits        12051    11799     -252     
+ Misses       7691     7676      -15     
+ Partials      303      287      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

displague
displague previously approved these changes Dec 13, 2023
@t0mk
Copy link
Contributor

t0mk commented Dec 13, 2023

Looks good. I tried TestAccDataSourceMetalDevice_byID locally and it passed.

@ctreatma
Copy link
Contributor Author

@displague I removed the unnecessary metalv1 alias from the import statements since the package is already called metalv1. Could you review again?

@ctreatma ctreatma merged commit f51b3b0 into main Dec 14, 2023
4 of 5 checks passed
@ctreatma ctreatma deleted the equinix-sdk-go branch December 14, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants