Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixing schemas for Servicetoken and accesspoint.interface. #472

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

srushti-patl
Copy link
Contributor

This PR includes fixes for two defects(CXF-81949 & CXF-81844)

  • fixed service token schema
  • fixed accespoint.interface schema

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2023

Codecov Report

Attention: 267 lines in your changes are missing coverage. Please review.

Comparison is base (26b2f3d) 60.11% compared to head (bf00bc8) 59.61%.
Report is 80 commits behind head on main.

Files Patch % Lines
equinix/fabric_mapping_helper.go 0.00% 68 Missing ⚠️
equinix/resource_fabric_connection.go 0.00% 39 Missing ⚠️
equinix/resource_fabric_cloud_router.go 0.00% 31 Missing ⚠️
equinix/resource_fabric_service_profile.go 0.00% 12 Missing ⚠️
equinix/resource_fabric_routing_protocol.go 0.00% 11 Missing ⚠️
equinix/resource_ecx_l2_connection.go 38.46% 8 Missing ⚠️
equinix/resource_ecx_l2_serviceprofile.go 38.46% 8 Missing ⚠️
equinix/resource_network_acl_template.go 0.00% 8 Missing ⚠️
equinix/resource_network_device.go 0.00% 8 Missing ⚠️
equinix/resource_network_device_link.go 0.00% 8 Missing ⚠️
... and 22 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #472      +/-   ##
==========================================
- Coverage   60.11%   59.61%   -0.51%     
==========================================
  Files          99       98       -1     
  Lines       20045    19939     -106     
==========================================
- Hits        12051    11886     -165     
- Misses       7691     7759      +68     
+ Partials      303      294       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

thogarty
thogarty previously approved these changes Dec 2, 2023
Copy link
Contributor

@thogarty thogarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one requested change. Looks good aside from that.

equinix/resource_fabric_connection.go Outdated Show resolved Hide resolved
Copy link
Contributor

@thogarty thogarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ship it.

@srushti-patl srushti-patl merged commit e26dc73 into main Dec 5, 2023
4 of 5 checks passed
@srushti-patl srushti-patl deleted the CXF-81844 branch December 5, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants