Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make correrlationI() function private #465

Merged
merged 1 commit into from
Nov 16, 2023
Merged

fix: make correrlationI() function private #465

merged 1 commit into from
Nov 16, 2023

Conversation

t0mk
Copy link
Contributor

@t0mk t0mk commented Nov 16, 2023

CorrelationId was moved to internal/config and accidental made public. This PR makes it private.

@t0mk t0mk requested review from displague and ctreatma November 16, 2023 14:55
@ocobles ocobles self-requested a review November 16, 2023 14:57
@ocobles ocobles marked this pull request as ready for review November 16, 2023 14:57
ocobles
ocobles approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@ocobles ocobles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Merging since this change doesn't affect e2e running test

@ocobles ocobles merged commit e1583cb into main Nov 16, 2023
7 of 8 checks passed
@ocobles ocobles deleted the config_to_config/internal branch November 16, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocobles ocobles ocobles approved these changes

@displague displague Awaiting requested review from displague

@ctreatma ctreatma Awaiting requested review from ctreatma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t0mk @ocobles