-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: equinix_fabric_cloud_router provisioning state and read schema #457
Conversation
Signed-off-by: ocobleseqx <[email protected]>
Signed-off-by: ocobleseqx <[email protected]>
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #457 +/- ##
==========================================
- Coverage 60.11% 59.68% -0.44%
==========================================
Files 99 99
Lines 20045 20098 +53
==========================================
- Hits 12051 11995 -56
- Misses 7691 7801 +110
+ Partials 303 302 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks, @ocobles !
Signed-off-by: ocobleseqx <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good update. Still LGTM. Approved.
fix #455 - assign missed values in setMap:
fix #456
Update
waitUntilCloudRouterIsProvisioned
with values included in https://app.swaggerhub.com/apis/equinix-api/fabric/4.10#/CloudRouterAccessPointState (LOCKED not included due to lack of information, I don't know the FCR life cycle