Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: equinix_fabric_cloud_router provisioning state and read schema #457

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

ocobles
Copy link
Contributor

@ocobles ocobles commented Nov 13, 2023

fix #455 - assign missed values in setMap:

		"equinix_asn":           fcr.EquinixAsn,
		"bgp_ipv4_routes_count": fcr.BgpIpv4RoutesCount,
		"bgp_ipv6_routes_count": fcr.BgpIpv6RoutesCount,
		"connections_count":     fcr.ConnectionsCount,
		"order":                 orderToTerra(fcr.Order),

fix #456
Update waitUntilCloudRouterIsProvisioned with values included in https://app.swaggerhub.com/apis/equinix-api/fabric/4.10#/CloudRouterAccessPointState (LOCKED not included due to lack of information, I don't know the FCR life cycle

ocobleseqx added 2 commits November 13, 2023 23:57
@ocobles ocobles changed the title Fix equinix_fabric_cloud_router fix: equinix_fabric_cloud_router Nov 13, 2023
@ocobles ocobles changed the title fix: equinix_fabric_cloud_router fix: equinix_fabric_cloud_router provisioning state and read schema Nov 13, 2023
@ocobles ocobles requested review from manu-equinix and thogarty and removed request for manu-equinix November 13, 2023 23:11
@codecov-commenter
Copy link

Codecov Report

Attention: 97 lines in your changes are missing coverage. Please review.

Comparison is base (26b2f3d) 60.11% compared to head (692f2ce) 59.68%.
Report is 48 commits behind head on main.

Files Patch % Lines
equinix/fabric_mapping_helper.go 0.00% 54 Missing ⚠️
equinix/resource_fabric_cloud_router.go 0.00% 20 Missing ⚠️
equinix/resource_fabric_connection.go 0.00% 14 Missing ⚠️
equinix/data_source_metal_device.go 89.47% 3 Missing and 1 partial ⚠️
equinix/resource_metal_device.go 87.50% 3 Missing and 1 partial ⚠️
equinix/helpers_device.go 97.14% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #457      +/-   ##
==========================================
- Coverage   60.11%   59.68%   -0.44%     
==========================================
  Files          99       99              
  Lines       20045    20098      +53     
==========================================
- Hits        12051    11995      -56     
- Misses       7691     7801     +110     
+ Partials      303      302       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

thogarty
thogarty previously approved these changes Nov 14, 2023
Copy link
Contributor

@thogarty thogarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, @ocobles !

@ocobles
Copy link
Contributor Author

ocobles commented Nov 15, 2023

@thogarty it will need another review. Some of the added fields were only in the read schema f7a6753

Now I can see all new fields upon import
image

Copy link
Contributor

@thogarty thogarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good update. Still LGTM. Approved.

@displague displague merged commit e3509df into main Nov 15, 2023
4 of 5 checks passed
@displague displague deleted the fix-fcr branch November 15, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants