Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the correct base User-Agent for metal-go requests #437

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

ctreatma
Copy link
Contributor

@ctreatma ctreatma commented Nov 2, 2023

The code that injects terraform module information into the User-Agent string for the metal-go client was mis-wired; it was using the packngo User-Agent as a base instead of the metal-go User-Agent. This change will correct the User-Agent so that requests made with metal-go will not appear to come from packngo.

The code that injects terraform module information into the User-Agent
string for the metal-go client was mis-wired; it was using the packngo
User-Agent as a base instead of the metal-go User-Agent.  This change
will correct the User-Agent so that requests made with metal-go will
not appear to come from packngo.
@ctreatma ctreatma temporarily deployed to internal November 2, 2023 15:42 — with GitHub Actions Inactive
@codecov-commenter
Copy link

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (26b2f3d) 60.11% compared to head (dcfc5f4) 60.03%.
Report is 31 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #437      +/-   ##
==========================================
- Coverage   60.11%   60.03%   -0.09%     
==========================================
  Files          99       99              
  Lines       20045    20040       -5     
==========================================
- Hits        12051    12031      -20     
- Misses       7691     7704      +13     
- Partials      303      305       +2     
Files Coverage Δ
equinix/config.go 64.36% <100.00%> (+1.06%) ⬆️
equinix/errors.go 86.95% <100.00%> (+0.59%) ⬆️
equinix/fabric_cloud_router_schema.go 100.00% <100.00%> (ø)
equinix/helpers_device.go 82.26% <97.14%> (-2.65%) ⬇️
equinix/fabric_mapping_helper.go 0.77% <0.00%> (ø)
equinix/data_source_metal_device.go 88.33% <89.47%> (-0.71%) ⬇️
equinix/resource_fabric_cloud_router.go 9.69% <0.00%> (-0.05%) ⬇️
equinix/resource_metal_device.go 78.63% <87.50%> (-0.45%) ⬇️
equinix/resource_fabric_connection.go 5.75% <0.00%> (-0.09%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@displague displague merged commit 39c721c into main Nov 2, 2023
4 of 5 checks passed
@displague displague deleted the fix-metal-go-user-agent branch November 2, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants