fix: read metal-go client's auth token from config, not env #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the metal-go client was introduced to enable packngo deprecation, it was wired up directly to the `METAL_AUTH_TOKEN` environment variable for auth. This breaks auth when a customer is using the `auth_token` provider configuration. This updates the metal-go client initialization so that the client will work with both the `auth_token` setting and the `METAL_AUTH_TOKEN` env var.
displague
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the metal-go client was introduced to enable packngo deprecation, it was wired up directly to the
METAL_AUTH_TOKENenvironment variable for auth. This breaks auth when a customer is using theauth_tokenprovider configuration.This updates the metal-go client initialization so that the client will work with both the
auth_tokensetting and theMETAL_AUTH_TOKENenv var.