Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump google.golang.org/grpc from 1.57.0 to 1.57.1 #427

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 25, 2023

Bumps google.golang.org/grpc from 1.57.0 to 1.57.1.

Release notes

Sourced from google.golang.org/grpc's releases.

Release 1.57.1

Security

  • server: prohibit more than MaxConcurrentStreams handlers from running at once (CVE-2023-44487)

    In addition to this change, applications should ensure they do not leave running tasks behind related to the RPC before returning from method handlers, or should enforce appropriate limits on any such work.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.57.0 to 1.57.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.57.0...v1.57.1)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 25, 2023
@dependabot dependabot bot temporarily deployed to internal October 25, 2023 21:45 Inactive
@codecov-commenter
Copy link

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (26b2f3d) 60.11% compared to head (bc5ba8c) 60.06%.
Report is 22 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
- Coverage   60.11%   60.06%   -0.06%     
==========================================
  Files          99       99              
  Lines       20045    20033      -12     
==========================================
- Hits        12051    12032      -19     
- Misses       7691     7699       +8     
+ Partials      303      302       -1     
Files Coverage Δ
equinix/errors.go 86.95% <100.00%> (+0.59%) ⬆️
equinix/helpers_device.go 82.26% <97.14%> (-2.65%) ⬇️
equinix/data_source_metal_device.go 88.33% <89.47%> (-0.71%) ⬇️
equinix/resource_metal_device.go 78.63% <87.50%> (-0.45%) ⬇️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@displague
Copy link
Member

displague commented Oct 26, 2023

I see this in the E2E log:

=== CONT  TestAccMetalDevice_importBasic
    resource_metal_device_acc_test.go:667: failed to create new working directory: unable to disable terraform-exec provider verification: fork/exec /tmp/plugintest-terraform2730119545/terraform: text file busy
--- FAIL: TestAccMetalDevice_importBasic (0.82s)

I don't know that I've seen that exact flake before but I'm not prepared to merge this even though this is merely a patch release of a dependency.

GRPC ddos prevention could result in scenarios like "text file busy" happening more often.

I'm curious how other providers, maintained by Hashicorp, are proceeding. I could imagine an upstream improvement to how the grpc sockets are managed.

@displague
Copy link
Member

@displague
Copy link
Member

https://github.com/grpc/grpc-go/releases
1.59.0 is latest

Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 16, 2023

Looks like google.golang.org/grpc is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Nov 16, 2023
@dependabot dependabot bot deleted the dependabot/go_modules/google.golang.org/grpc-1.57.1 branch November 16, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants